Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#567 fix for ordered factors in tbl_summary #568

Merged
merged 12 commits into from
Jul 20, 2020
Merged

Conversation

ddsjoberg
Copy link
Owner

@ddsjoberg ddsjoberg commented Jul 8, 2020

What changes are proposed in this pull request?
tbl_summary() was erring when summary variables were ordered factors. This PR fixes the bug.

However, the fix does strip the variable label from the ordered factor, and we're not recovering it. I don't think too many people are using ordered factors (this is the first we're hearing of the bug), and of those, how many are using labels? This issue will be addressed in a future pull request #569

If there is an GitHub issue associated with this pull request, please provide link.
closes #567


Checklist for PR reviewer

  • PR branch has pulled the most recent updates from master branch
  • NEWS.md has been updated under the heading "# gtsummary (development version)"?
  • usethis::use_spell_check() runs with no spelling errors in documentation
  • If a new function was added, function included in pkgdown.yml
  • If a bug was fixed, a unit test was added for the bug check
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features. Review coverage with covr::report().
  • R CMD Check runs without errors, warnings, and notes
  • When the branch is ready to be merged into master, increment the version number using usethis::use_version(which = "dev"), run codemetar::write_codemeta(), approve, and merge the PR.

Copy link
Contributor

@michaelcurry1123 michaelcurry1123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed the bug! @ddsjoberg I will let you merge to master and bump the version since I did not do it right last time!

@ddsjoberg ddsjoberg merged commit 52f8c68 into master Jul 20, 2020
@ddsjoberg ddsjoberg deleted the 567_ordered_factor_fix branch July 20, 2020 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error with diamonds dataset (ordered factors?)
3 participants