-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allowing for any class to be passed to tbl_summary #603
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@karissawhiting this is not pressing in any way. But when you have a chance can you begin testing and give feedback? |
/document |
closing in favor of PR #794 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR allows columns of any class to be summarized by
tbl_summary()
.Outstanding items:
.$meta_data
indicating if the column is a base R type/class. When there are errors with non-base types, we could pass a special error message.Haven labelled example
If there is an GitHub issue associated with this pull request, please provide link.
closes #569
closes #488
closes #540
Checklist for PR reviewer
tbl_summary()
, was the same change implemented fortbl_svysummary()
?_pkgdown.yml
pkgdown::build_site()
. Check the R console for errors, and review the rendered website.covr::report()
. Before you run, setSys.setenv(NOT_CRAN = TRUE)
and begin in a fresh R session without any packages loaded.# gtsummary (development version)
". If there is an issue associated with the pull request, reference it in parantheses at the end update (see NEWS.md for examples).usethis::use_spell_check()
runs with no spelling errors in documentationusethis::use_version(which = "dev")
, runcodemetar::write_codemeta()
, approve, and merge the PR.