Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding remove_row_type() #696

Merged
merged 4 commits into from
Nov 27, 2020
Merged

Adding remove_row_type() #696

merged 4 commits into from
Nov 27, 2020

Conversation

ddsjoberg
Copy link
Owner

@ddsjoberg ddsjoberg commented Nov 1, 2020

What changes are proposed in this pull request?
Added function remove_row_type().

If there is an GitHub issue associated with this pull request, please provide link.
closes #678


Checklist for PR reviewer

  • PR branch has pulled the most recent updates from master branch. Ensure the pull request branch and your local version match and both have the latest updates from the master branch.
  • If an update was made to tbl_summary(), was the same change implemented for tbl_svysummary()?
  • If a new function was added, function included in _pkgdown.yml
  • If a bug was fixed, a unit test was added for the bug check
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features. Review coverage with covr::report(). Before you run, set Sys.setenv(NOT_CRAN=true) and begin in a fresh R session without any packages loaded.
  • R CMD Check runs without errors, warnings, and notes
  • NEWS.md has been updated with the changes from this pull request under the heading "# gtsummary (development version)". If there is an issue associated with the pull request, reference it in parantheses at the end update (see NEWS.md for examples).
  • usethis::use_spell_check() runs with no spelling errors in documentation
  • When the branch is ready to be merged into master, increment the version number using usethis::use_version(which = "dev"), run codemetar::write_codemeta(), approve, and merge the PR. Please use "Suash and merge".

@ddsjoberg ddsjoberg marked this pull request as ready for review November 11, 2020 17:42
@ddsjoberg ddsjoberg added enhancement 🌟 New feature or request good for beginners ❤️ help wanted Extra attention is needed labels Nov 24, 2020
@ddsjoberg ddsjoberg merged commit 420815f into master Nov 27, 2020
@ddsjoberg ddsjoberg deleted the remove_rows_fn branch November 27, 2020 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🌟 New feature or request good for beginners ❤️ help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a no_reference_row option to tbl_regression()
1 participant