Skip to content

Commit

Permalink
fs-proc-task_mmuc-simplify-the-vma_stop-logic-checkpatch-fixes
Browse files Browse the repository at this point in the history
WARNING: Missing a blank line after declarations
torvalds#50: FILE: fs/proc/task_mmu.c:135:
+	struct mm_struct *mm = priv->mm;
+	release_task_mempolicy(priv);

ERROR: spaces required around that '?' (ctx:VxW)
torvalds#86: FILE: fs/proc/task_mmu.c:220:
+	next = (vma != tail_vma)? tail_vma: NULL;
 	                        ^

ERROR: spaces required around that ':' (ctx:VxW)
torvalds#86: FILE: fs/proc/task_mmu.c:220:
+	next = (vma != tail_vma)? tail_vma: NULL;
 	                                  ^

total: 2 errors, 1 warnings, 65 lines checked

./patches/fs-proc-task_mmuc-simplify-the-vma_stop-logic.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
  • Loading branch information
akpm00 authored and sfrothwell committed Sep 23, 2014
1 parent 6705cfd commit 5a9f4b7
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion fs/proc/task_mmu.c
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@ static void release_task_mempolicy(struct proc_maps_private *priv)
static void vma_stop(struct proc_maps_private *priv)
{
struct mm_struct *mm = priv->mm;

release_task_mempolicy(priv);
up_read(&mm->mmap_sem);
mmput(mm);
Expand Down Expand Up @@ -217,7 +218,7 @@ static void *m_next(struct seq_file *m, void *v, loff_t *pos)
if (vma && (vma != tail_vma) && vma->vm_next)
return vma->vm_next;

next = (vma != tail_vma)? tail_vma: NULL;
next = (vma != tail_vma) ? tail_vma : NULL;
if (!next)
vma_stop(priv);
return next;
Expand Down

0 comments on commit 5a9f4b7

Please sign in to comment.