Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering problems of Version 2.6.0 #438

Closed
1 of 2 tasks
de-jcup opened this issue Jul 26, 2022 · 2 comments
Closed
1 of 2 tasks

Fix rendering problems of Version 2.6.0 #438

de-jcup opened this issue Jul 26, 2022 · 2 comments
Assignees
Milestone

Comments

@de-jcup
Copy link
Owner

de-jcup commented Jul 26, 2022

Situation

With Version 2.6.0 it is not possible to open /render Asciidoc files.
Always having the problem - sound similar to #412 which should be fixed by the changes in 2.6.0 but now it happens also on a Linux machine (but only in installed plugin, but not in runtime (developer) version) - strange...

Wanted

Fix the problem and have no installation of 2.6.0

Solution

  • Changed marketplace setup back to 2.5.1 so users do not download/install 2.6.0
  • Find the problem and fix it!
@de-jcup
Copy link
Owner Author

de-jcup commented Jul 26, 2022

Analyse

  • plain asciidoc files do work
  • problems appear where a diagram (plantuml, ditaa etc.) is referenced. Those files cannot longer be found - reason: diagram path is wrong calculated!
  • in general: the base path calculation is absolutely wrong, could be related to the changes made for Empty folder between asciidoc files prevents plantuml resolution #428
  • Setting AsciiDoctorBaseDirectoryProvider.MAX_ACCPTED_EMPTY_FOLDERS to 0, does solve the problem

@de-jcup
Copy link
Owner Author

de-jcup commented Jul 26, 2022

The solution is, to remove the implementation of #428 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant