Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty folder between asciidoc files prevents plantuml resolution #428

Closed
de-jcup opened this issue Jul 5, 2022 · 2 comments
Closed

Empty folder between asciidoc files prevents plantuml resolution #428

de-jcup opened this issue Jul 5, 2022 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@de-jcup
Copy link
Owner

de-jcup commented Jul 5, 2022

Situation

documents
  | main.adoc
  |-----folder2 (empty)
  |          ^---------folder3
  |                           subdocument.adoc
diagrams
  my_diagram.puml

When wrring subdocument.adoc like this:

=== Inside subdocument

lorem ipsum..

plantuml::diagrams/my_diagram.puml[]

The files is not correct rendered (neither ASP nor by native asciidoc)

Analyze

The problem is the base class calculation! The empty folder will be used as the new base and so the diagram will not be found.

Wanted

Improve the base directory resolution

Solution

Workaround: Just add an empty asciidoc file - e.g. pseudo.adoc and the resolution will work again.

A real solution is still open

@de-jcup de-jcup added the bug Something isn't working label Jul 5, 2022
@de-jcup de-jcup added this to the 2.6.0 milestone Jul 25, 2022
@de-jcup
Copy link
Owner Author

de-jcup commented Jul 25, 2022

We allow now up to 3 empty folders while resolving base directory

@de-jcup
Copy link
Owner Author

de-jcup commented Jul 26, 2022

Version 2.6.0 did fail when it comes to rendering of bigger documentation projects - e.g. https://github.com/mercedes-benz/sechub/tree/develop/sechub-doc . The diagram path calculation did fail.

Looking back, one has to say that the idea wasn't a very happy or good one. The workaround of putting an empty Asciidoc document in an empty folder is much better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant