Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Initial prototype for ignore files #144

Closed
wants to merge 1 commit into from
Closed

[WIP] Initial prototype for ignore files #144

wants to merge 1 commit into from

Conversation

jyn514
Copy link
Contributor

@jyn514 jyn514 commented Jan 19, 2021

For #133

This still needs tests. Also ignoring slice doesn't work:

Found invalid urls in std/primitive.slice.html:
	Linked file at path /home/joshua/rustc3/build/x86_64-unknown-linux-gnu/std/primitive.slice.html does not exist!
	Linked file at path /home/joshua/rustc3/build/x86_64-unknown-linux-gnu/std/primitive.slice.html does not exist!

but I don't know if that's because ignoring files in general is broken, or because the link is outside the doc directory.

@jyn514 jyn514 added the S-waiting-on-author Status: Waiting on the author of this PR or issue label Jan 19, 2021
@jyn514
Copy link
Contributor Author

jyn514 commented Feb 15, 2022

I don't think anyone is going to actually use this.

@jyn514 jyn514 closed this Feb 15, 2022
@jyn514 jyn514 deleted the ignore-links branch February 15, 2022 04:42
@laysakura
Copy link

@jyn514 We hope this feature for the following reason.

SpringQL/SpringQL#166

Currently we should hold ignore list by a dirty format...
SpringQL/SpringQL#175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-author Status: Waiting on the author of this PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jyn514 @laysakura