fix(ui): Fix incorrect env var existence check (caraml-dev#102)

* Fix incorrect env var existence check * Add codecov threshold
deadlycoconuts · Jun 4, 2024 · 52ecdaa · 52ecdaa
1 parent 5d5a1b9
commit 52ecdaa
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/.github/workflows/ci-pipeline.yml b/.github/workflows/ci-pipeline.yml
@@ -130,6 +130,7 @@ jobs:
           name: api-test
           token: ${{ secrets.CODECOV_TOKEN }}
           working-directory: ./api
+          codecov_yml_path: ../.github/workflows/codecov-config/codecov.yml
 
   e2e-test:
     runs-on: ubuntu-latest

diff --git a/.github/workflows/codecov-config/codecov.yml b/.github/workflows/codecov-config/codecov.yml
@@ -0,0 +1,5 @@
+coverage:
+  status:
+    patch:
+      default:
+        threshold: 0.03%
diff --git a/ui/packages/app/src/config.js b/ui/packages/app/src/config.js
@@ -1,5 +1,5 @@
 const getEnv = env => {
-  return window.env && window.env[env] ? window.env[env] : process.env[env];
+  return window.env && env in window.env ? window.env[env] : process.env[env];
 };
 
 export const sentryConfig = {