-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prometheus.Erlang: Fix Kernel.Utils.defdelegate usage for Elixir 1.14 #47
Conversation
Elixir 1.14 changed Kernel.Utils.defdelegate/2 into Kernel.Utils.defdelegate_each/2
Elixir v1.14 is officially released yesterday 🎉 This change would be way much more appreciate now 🙏🏽 |
Can this be merged? Would be great, thanks! |
I don't know if it helps, but we're using this commit in production for several weeks, all good 👍🏽 |
Branch works for me as well and also hoping this can be merged, Thank you! |
Really interested in this too. By, chance do you have some estimation to merge and release it? Also if there's something that I can help with, just let me know. |
Can I please not have yet another "Works For Me"?
It's nice to know but I think that point has been well proven by now.
|
Could this PR be merged and released in a new version, please? |
Any news on this one? @deadtrickster maybe? Thx! |
@deadtrickster Hi! This PR is ready to merge. |
Still not merged, fr :/ |
I don't need this anymore - I've migrated to telemetry and telemetry_metrics_prometheus_core. |
@deadtrickster ping 🙏 🙏 🙏 |
@deadtrickster @ikvmw please merge 🙏 🙏 🙏 🙏 🙏 🙏 🙏 |
Elixir v1.15 is officially released yesterday 🎉 |
@deadtrickster or @ikvmw Any update here? |
@deadtrickster We are waiting to merge 😭 😭 😭 |
Bump on this, would be great to merge... 🙏 |
just to add more nagging, can this be merge? the community is going to hurt unless we start forking (which is not really a good place to be either) @deadtrickster please? can you help? who else is a project owner here? |
for those who need, I updated also the deps and merge the fix here for now https://github.com/podium/prometheus.ex as another option |
Sorry, I forgot 🤷♂️ |
published package as well |
Thanks @deadtrickster ! |
thanks! @deadtrickster |
Thanks @deadtrickster ! |
Thank you @deadtrickster |
😊 |
Elixir 1.14 changed Kernel.Utils.defdelegate/2 into Kernel.Utils.defdelegate_each/2