Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: translate bills in a single web page by wasm #77

Merged
merged 17 commits into from
Dec 20, 2022
Merged

feat: translate bills in a single web page by wasm #77

merged 17 commits into from
Dec 20, 2022

Conversation

Triple-Z
Copy link
Member

Signed-off-by: TripleZ me@triplez.cn

@Triple-Z Triple-Z requested review from gaocegege and a team as code owners December 17, 2022 07:28
@Triple-Z Triple-Z marked this pull request as draft December 17, 2022 07:28
@Triple-Z
chore: sync go packages
9b03f5b 
Signed-off-by: TripleZ <me@triplez.cn>
@Triple-Z
feat(wasm): now wasm output can print on html!
500b6be 
TODO:
- build constraints for `syscall/js`.
- index page read input/config from their textarea.

Signed-off-by: TripleZ <me@triplez.cn>
@Triple-Z
Copy link
Member Author

Triple-Z commented Dec 17, 2022 •
edited
Loading

TODO:

  • build constraints for syscall/js. [MVP]
  • index page read input/config from their textarea. [MVP]
  • support wechat provider.
  • support alipay provider.
  • support huobi provider.
  • support htsec provider (using excelize, need to re-write the reader). feat(wasm): support htsec provider #78
  • raise notification if translate occurs an error.
  • Error: bad flag syntax (use -- to terminate options)
  • --output can be html tag id in wasm.

@Triple-Z
refact: isolate syscall/js, add js/wasm build constraints.
25605ee 
Signed-off-by: TripleZ <me@triplez.cn>
@Triple-Z
fix: build error in normal mode
5b424f7 
Signed-off-by: TripleZ <me@triplez.cn>
@Triple-Z
chore: remove all debug logs
a8b4d87 
Signed-off-by: TripleZ <me@triplez.cn>
@Triple-Z
feat(wasm): support alipay & huobi providers
63577c1 
Signed-off-by: TripleZ <me@triplez.cn>
@Triple-Z
Copy link
Member Author

@gaocegege now you can review all the go code under the pkg directory.

@Triple-Z
Copy link
Member Author

Triple-Z commented Dec 19, 2022 •
edited
Loading

Known issues:

@Triple-Z Triple-Z marked this pull request as ready for review December 20, 2022 02:38
@Triple-Z Triple-Z changed the title WIP: translate bills in a single web page by wasm feat: translate bills in a single web page by wasm Dec 20, 2022
@Triple-Z
fix(wasm): using -- to terminate options to prevent "bad flag syntax"
54f727b 
Signed-off-by: TripleZ <me@triplez.cn>
@Triple-Z
feat(wasm): add binary's version
37d3c23 
Signed-off-by: TripleZ <me@triplez.cn>
gaocegege
gaocegege reviewed Dec 20, 2022
View reviewed changes
pkg/cmd/translate.go Outdated Show resolved Hide resolved
pkg/config/init_config_wasm.go Show resolved Hide resolved
pkg/io/reader/file_reader.go Show resolved Hide resolved
pkg/provider/alipay/alipay.go Outdated Show resolved Hide resolved
@Triple-Z
feat(wasm): fetch wasm binary only once!
f9e0c89 
fix goimports.

Signed-off-by: TripleZ <me@triplez.cn>
@Triple-Z
chore: lint GO files
f52d44b 
Signed-off-by: TripleZ <me@triplez.cn>
@Triple-Z
feat(wasm): support using different output element by id
eeeb6da 
Signed-off-by: TripleZ <me@triplez.cn>
@Triple-Z Triple-Z merged commit 864a4f6 into master Dec 20, 2022
@Triple-Z Triple-Z deleted the feat-wasm-build branch December 20, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Triple-Z @gaocegege