stream: dont access Object.prototype.type during TransformStream init

Fixes: nodejs#46355
debadree25 · Jan 28, 2023 · b2a828b · b2a828b
1 parent 47cd966
commit b2a828b
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/lib/internal/webstreams/transformstream.js b/lib/internal/webstreams/transformstream.js
@@ -368,6 +368,7 @@ function initializeTransformStream(
     close() {
       return transformStreamDefaultSinkCloseAlgorithm(stream);
     },
+    __proto__: null
   }, {
     highWaterMark: writableHighWaterMark,
     size: writableSizeAlgorithm,
@@ -382,6 +383,7 @@ function initializeTransformStream(
       transformStreamErrorWritableAndUnblockWrite(stream, reason);
       return PromiseResolve();
     },
+    __proto__: null,
   }, {
     highWaterMark: readableHighWaterMark,
     size: readableSizeAlgorithm,

diff --git a/test/parallel/test-whatwg-transformstream.js b/test/parallel/test-whatwg-transformstream.js
@@ -186,3 +186,18 @@ class Source {
     inspect(controller, { depth: 0 }),
     /TransformStreamDefaultController \[/);
 }
+
+{
+  Object.defineProperty(Object.prototype, 'type', {
+    get: common.mustNotCall()
+  });
+
+  new TransformStream({
+    transform(chunk, controller) {
+      controller.enqueue(chunk);
+    },
+    flush(controller) {
+      controller.terminate();
+    }
+  });
+}