Handle undefined errors in getAllInfo (winstonjs#2208)

debadutta98 · Oct 18, 2022 · 8769d47 · 8769d47
1 parent a52608c
commit 8769d47
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/lib/winston/exception-handler.js b/lib/winston/exception-handler.js
@@ -73,9 +73,9 @@ module.exports = class ExceptionHandler {
    * @returns {mixed} - TODO: add return description.
    */
   getAllInfo(err) {
-    let { message } = err;
-    if (!message && typeof err === 'string') {
-      message = err;
+    let message = null;
+    if (err) {
+      message = typeof err === 'string' ? err : err.message;
     }
 
     return {
@@ -84,9 +84,9 @@ module.exports = class ExceptionHandler {
       level: 'error',
       message: [
         `uncaughtException: ${(message || '(no error message)')}`,
-        err.stack || '  No stack trace'
+        err && err.stack || '  No stack trace'
       ].join('\n'),
-      stack: err.stack,
+      stack: err && err.stack,
       exception: true,
       date: new Date().toString(),
       process: this.getProcessInfo(),

diff --git a/test/unit/winston/exception-handler.test.js b/test/unit/winston/exception-handler.test.js
@@ -106,6 +106,12 @@ describe('ExceptionHandler', function () {
     helpers.throw('wtf this error');
   });
 
+  it('.getAllInfo(undefined)', function () {
+    var handler = helpers.exceptionHandler();
+    // eslint-disable-next-line no-undefined
+    handler.getAllInfo(undefined);
+  });
+
   after(function () {
     //
     // Restore normal `runTest` functionality