Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix that having the node-rating toolbar-items visible (when timeline->playing panel is open) makes map-scrolling a lot slower #244

Closed
Venryx opened this issue Nov 15, 2023 · 0 comments
Closed

Fix that having the node-rating toolbar-items visible (when timeline->playing panel is open) makes map-scrolling a lot slower #244

Venryx opened this issue Nov 15, 2023 · 0 comments
Labels
bug frontend Requiring changes to the frontend code (TypeScript)

Comments

@Venryx
Copy link
Collaborator

Venryx commented Nov 15, 2023 •
edited
Loading

Notes:

  • Also, issue seems to only happen when the "Layout-helper map: Load" setting is enabled.
  • The causing-conditions seem to not be cut and dry: eg. sometimes issue happens even when rating buttons are hidden. (probably a browser buffer for fast-scrolling is reaching its memory limit or something)
@Venryx Venryx added bug frontend Requiring changes to the frontend code (TypeScript) labels Nov 15, 2023
@Venryx Venryx changed the title Fix that having the node-rating toolbar-items visible makes map-scrolling a lot slower (presumably scrolls are triggering the container resize-detector for the chart components) Fix that having the node-rating toolbar-items visible (when timeline->playing panel is open) makes map-scrolling a lot slower Nov 15, 2023
@Venryx Venryx closed this as completed Nov 22, 2023
Venryx added a commit that referenced this issue Nov 22, 2023
@Venryx
* Fixed that map-scrolling was a lot slower than normal, when having …
09b6960 
…the node-rating toolbar-items visible (when timeline->playing panel was open). Closes #244.

* Fixed occasional render error when timeline panel was open, after leaving then coming back to page (after websocket dc).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug frontend Requiring changes to the frontend code (TypeScript)
Projects
Public task list
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Venryx