Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Disable plain text converters to support Unicode with XWindowsClipboard #461

Closed
wants to merge 1 commit into from

Conversation

pdecat
Copy link

@pdecat pdecat commented Oct 12, 2019

This PRs aims to resolve issue #344, where Unicode characters pasted to linux client or server are replaced by question marks.

This is marked as WIP as I'm still investigating why the text/plain converter is selected instead of the Unicode one.

The current change is more like a work-around that disables plain text converters for
XWindowsClipboard. Did not notice side effects yet.

@pdecat
Copy link
Author

pdecat commented Oct 12, 2019

Note: the Windows Clipboard had its plain text converter disabled years ago: 3ddb7ef#diff-8d79106a107fa1e6578a4bb0cde4db76L46

@AdrianKoshka
Copy link

Thanks for looking into this issue and contributing.

@pdecat
Copy link
Author

pdecat commented Oct 18, 2019

I did not dig any further for the root cause. No issue with this change so far for me.

To avoid breaking stuff for others, maybe this could be made an option defaulting to old behavior.
Or take a little more risk and make the default depend on the user's locale:

  • *.UTF-8 => disable plain text converters by default
  • anything else => keep them enabled by default

@eizanprime
Copy link

I tried this PR and it works very well, I can copy-paste unicode text from windows client to linux server with no problem now (which would get replaced by ?? without this PR)

@p12tic
Copy link
Member

p12tic commented Dec 17, 2019

The fix is more like a hack, we need to figure out why correct converter is not selected. I suspect the real bug is in that part of the code.

…ing issues with Unicode characters being replaced by question marks debauchee#344
@pdecat pdecat force-pushed the fix_unicode_question_marks branch from b76e7e1 to 41a64e1 Compare March 3, 2020 06:48
@pdecat
Copy link
Author

pdecat commented Mar 9, 2020

There is this fix in upstream that may be related https://github.com/symless/synergy-core/pull/6617

@pdecat pdecat closed this Mar 9, 2020
@pdecat pdecat reopened this Mar 9, 2020
@shymega
Copy link

shymega commented Aug 31, 2020

Related to #860.

@yan12125
Copy link

Based on this PR, I created another PR #1164. I believe that one is a correct fix. Hope it helps :)

@pdecat pdecat closed this Jun 13, 2021
@pdecat
Copy link
Author

pdecat commented Jun 13, 2021

Superseded by #1164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants