-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Disable plain text converters to support Unicode with XWindowsClipboard #461
Conversation
Note: the Windows Clipboard had its plain text converter disabled years ago: 3ddb7ef#diff-8d79106a107fa1e6578a4bb0cde4db76L46 |
Thanks for looking into this issue and contributing. |
I did not dig any further for the root cause. No issue with this change so far for me. To avoid breaking stuff for others, maybe this could be made an option defaulting to old behavior.
|
I tried this PR and it works very well, I can copy-paste unicode text from windows client to linux server with no problem now (which would get replaced by ?? without this PR) |
The fix is more like a hack, we need to figure out why correct converter is not selected. I suspect the real bug is in that part of the code. |
…ing issues with Unicode characters being replaced by question marks debauchee#344
b76e7e1
to
41a64e1
Compare
There is this fix in upstream that may be related https://github.com/symless/synergy-core/pull/6617 |
Related to #860. |
Based on this PR, I created another PR #1164. I believe that one is a correct fix. Hope it helps :) |
Superseded by #1164 |
This PRs aims to resolve issue #344, where Unicode characters pasted to linux client or server are replaced by question marks.
This is marked as WIP as I'm still investigating why the
text/plain
converter is selected instead of the Unicode one.The current change is more like a work-around that disables plain text converters for
XWindowsClipboard. Did not notice side effects yet.