Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A guide about how to install the wal2json logical decoding plugin at Postgresql #204

Closed
wants to merge 1 commit into from
Closed

A guide about how to install the wal2json logical decoding plugin at Postgresql #204

wants to merge 1 commit into from

Conversation

jpsoroulas
Copy link
Contributor

A guide about how to install the wal2json logical decoding plugin at Postgresql

Details can be found at the discussion with @gunnarmorling :
https://groups.google.com/forum/#!topic/debezium/h5B52YTkGR4

The contents of the https://debezium.io/docs/connectors/postgresql/#output-plugin
have been merged into the section one of https://gist.github.com/jpsoroulas/30e9537138ca62a79fe261cff7ceb716
but NOT REMOVED from the original page (the debezium page stills intact).

No link for this page is created at side-bar menu.
Access the page at /docs/install/postgres-plugins/

@jpechane
Copy link
Contributor

jpechane commented Oct 2, 2018

@jpsoroulas Thanks for the contribution, the text looks fine to me.
@gunnarmorling I think the page should be linked from somewhere, I do not like the notion of a hidden guide.

I am not 100 % sure of the text duplication, would not link be just enough? I understand the positives of have a single coherent text but I am not sure we would be able to keep it in sync.

@jpsoroulas
Copy link
Contributor Author

jpsoroulas commented Oct 2, 2018

@jpechane thanks for reviewing it,
In my opinion, I think a link would be fine,
I leave the decision to you.

@gunnarmorling
Copy link
Member

Rebased and applied. Thanks a lot, @jpsoroulas, and sorry again for the long delay with merging this.

I've also added a link to it from the actual Postgres connector config page. Regarding the redundancies between the two pages I think it would be nice to review the main connector page and get rid of the sections which are on that new page now.

@jpsoroulas
Copy link
Contributor Author

It is ok @gunnarmorling, it doesn't matter!
I really understand the pressure from supporting many projects. I really like this project and I constantly keep up with the project's latest news and I watch the forum closely and actively. I also have some ideas for writing code examples, I will post them to you when I am ready.

Regarding the redundancies between the two pages, I'll see what I can do.
And don't forget the PR #206 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants