Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary fix for #114 #116

Merged
merged 1 commit into from
Jul 26, 2016
Merged

Temporary fix for #114 #116

merged 1 commit into from
Jul 26, 2016

Conversation

vipentti
Copy link
Collaborator

IE11 Does not support creating Synthetic Events using new Event.

Temporary workaround using deprecated document.createEvent.

Tested on newest Firefox, Chrome, IE11 and Edge.

@OvermindDL1
Copy link
Contributor

Maybe it would be better to see if 'new Event' works and if so use it, else fallback to the old method? Or test if the old method still exists and use it, else use new Event? If the former is possible it would probably be better.

@vipentti
Copy link
Collaborator Author

That would be ideal but the inline javascript is getting out of hand already. If there was a better way to create methods in Javascript to be used with Elm without requiring external code then it might be worth it. An alternative is also a polyfill that might work, but that also requires external code.

new Event is the modern way and should be forward compatible and eventually the createEvent might be removed so hopefully before that the Elm focus/blur changes are added.

@vipentti vipentti merged commit 597b527 into debois:v6 Jul 26, 2016
@vipentti vipentti deleted the btn-ripple-fix-v6 branch September 1, 2016 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants