Fix is-focused not being triggered on Firefox #173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, Firefox does not support `focusin` and `focusout` events. This works around the issue by adding internal `focus` and `blur` handlers on the `input` element and then dispatching user provided `focus` and `blur` handlers in `update`.
| List.filterMap identity | ||
| [ msg |> Maybe.map Helpers.cmd ] | ||
| in | ||
| (model', Cmd.batch cmds) |
There was a problem hiding this comment.
Maybe lose cmds and just do
(model' , msg |> Maybe.map Helpers.cmd |> Maybe.withDefault Cmd.none)(Could also add that to Helpers as maybeCmd.)
|
I like this. I made a few line comments, in particular, I think |
|
Superceded by #179. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, Firefox does not support
focusinandfocusoutevents.This works around the issue by adding internal
focusandblurhandlers on the
inputelement and then dispatching user providedfocusandblurhandlers inupdate.Resolves #166