Initial implementation of generic attribute support #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry about the late reply. I like this! You closed it again? |
|
I guess I can update it if we want it in the current v7 |
This is a initial implementation of generic attribute support to enable arbitrary `Html.Attributes`. This implementation tries to minimize the likelyhood of overriding internally used attributes while still maintaining `MINOR` change. This implementation may be revisited in the next MAJOR version to update the implementation. Add namespaced qualifiers to `Internal.attribute`, this way internal attributes are easy to search for as well separate them from `Options.attribute`
vipentti
force-pushed
the
generic-attributes
branch
from
16ee5fc to
a342646
Compare
|
This should reduce the likelihood of overriding internal attributes by separating them. |
|
Just to be clear: #179 contains this already, yes? In that case, do we want this now, or can it wait for v8? |
|
Yes, #179 contains generic attribute support as well. We may wait or we may use this for now. Either way works for me. I think it depends if this is needed now and if v8 is some time a way still. |
|
Ok, let's do it. It keeps coming up. |
vipentti
added a commit
to vipentti/elm-mdl
that referenced
this pull request
Sep 11, 2016
This resolves debois#201. The implementation was simplified in a large way with debois#213.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a initial implementation of generic attribute support
to enable arbitrary
Html.Attributesto resolve #208 . This implementationtries to minimize the likelihood of overriding internally used
attributes while still maintaining
MINORchange.This implementation may be revisited in the next MAJOR version
to update the implementation.
Add namespaced qualifiers to
Internal.attribute,this way internal attributes are easy to search for as well separate
them from
Options.attribute.As always, open to feed back and suggestions!