Run git fetch before diffing the remote repository. #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For debops-update --dry-run to work properly, the remote needs to be fetched beforehand.
drybjed
approved these changes
Feb 17, 2017
|
It's a little bit of a stretch on what a dry run should be, but there's no way (that I'm aware of) around it. |
|
Sounds like there's no way to avoid the fetch so I suppose that's OK. New commits won't be merged to existing branch. |
|
@bfabio Note that the current implementation of reviewing could be exploited by our git hosting service (currently GitHub) as you do a fetch two times and the later one is used. Just something to note. It would be nice to see a more robust update mechanism implemented, one which is also tried with the debops-keyring (ref #164). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For debops-update --dry-run to work properly, the remote needs to be
fetched beforehand.