-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test-cases: add support for encrypted corpus #217
Conversation
@christian-intra2net encrypting files ends up breaking your unit test for json output. Do you have any suggestions on how to proceed? |
695654f
to
0b61807
Compare
Just stumbled over this, must have missed a notification I got referenced here. I guess the json unit test fails because it iterates over all files in tests/test-data and checks if running olevba[3]/msodde -j creates valid json, right. What does it produce for the encrypted zip? Did my last pull request solve this? Otherwise, what is the error? |
Here's the error I see in the Travis CI logs:
|
I see, then there is an easy fix which is adding "zip" to except_extns in tests.ooxml.test_basic.TestOOXML.test_rough_doctype . It will then ignore that file. Extending every test, that loops over all test data, to deal with encrypted zip files is probably not worth the effort, except if we plan on having lots more of zip-encrypted examples. In that case every "test-data walk()ing" test would have to be adapted (only a few at the moment). |
0b61807
to
1ab2893
Compare
Thanks for the hint @christian-intra2net, it's fixed now. |
To avoid triggering antivirus engines, we can encrypt files with a default password and decrypt them before testing.
1ab2893
to
fa39e4a
Compare
Some samples triggered antivirus engines, issues decalage2#215 and decalage2#217 ended with the agreement to encapsulate problematic samples in encrypted zip containers and decrypt them on-the-fly. Initial support for this was added but that did not cover 5 tests. Create on-the-fly decryption for these tests as well and re-enable them.
Some samples triggered antivirus engines, issues decalage2#215 and decalage2#217 ended with the agreement to encapsulate problematic samples in encrypted zip containers and decrypt them on-the-fly. Initial support for this was added but that did not cover 5 tests. Create on-the-fly decryption for these tests as well and re-enable them.
To avoid triggering antivirus engines, we can encrypt
files with a default password and decrypt them before
testing.
Closes #215