Msodde failed decrypt fix #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Error found by @decalage2 in PR #403 (and overlooked by me at first) |
christian-intra2net
force-pushed
the
msodde-failed-decrypt-fix
branch
from
619106c to
5e1667e
Compare
|
Rebased onto current master |
|
Hi @christian-intra2net, this one is now in conflict with your other PRs that I merged. Could you please check? |
|
I will, thanks for the note |
christian-intra2net
force-pushed
the
msodde-failed-decrypt-fix
branch
4 times, most recently
from
8f5ebe4 to
34681da
Compare
|
Finally, updated. The first motivating commit for this branch was already included in another pull request. Still, the other commits are worth merging, I think (update docs, create test). |
Might otherwise try to delete a non-existent file
pypy's json loader does not accept newlines in strings
json is messed up in pypy with warnings
christian-intra2net
force-pushed
the
msodde-failed-decrypt-fix
branch
from
34681da to
bb38dc6
Compare
|
Rebased onto current master |
decalage2
approved these changes
Jul 6, 2019
|
Thanks for merging :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a stupid little bug introduced when integrating crypto into msodde: check whether decryption actually worked and raise appropriate error if not.
Fixed this also in crypto recommendations and created a unittest