Update plugin to latest version #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current version has severe performance issues when analyzing some binary xls files. Updating to the latest plugin version solves the problem.
decalage2
approved these changes
Feb 18, 2020
|
@rsaccani could you please share some xls samples that cause performance issues? |
|
Here is a test sample. |
|
I tested the change after some necessary adaptations (783cf98), but when I try it on your sample, it still gets stuck somewhere in plugin_biff. There is a bug that needs to be fixed. :-/ |
|
A new version of plugin_biff was released with some "performance improvements". Applying them on the plugin file (with your patches) seems to fix it. DidierStevens/DidierStevensSuite@eb205ed#diff-2146c00278af18fcceb3041a386f3be1 |
|
@pupaxxo I know, Didier made the fix after I told him about this issue. ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version has severe performance issues when analyzing some binary xls files. Updating to the latest plugin version solves the problem.