Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slug string from URI-unsafe characters #501

Closed
kogai opened this issue Jul 27, 2017 · 1 comment
Closed

Slug string from URI-unsafe characters #501

kogai opened this issue Jul 27, 2017 · 1 comment

Comments

@kogai
Copy link

kogai commented Jul 27, 2017

- Do you want to request a feature or report a bug?

FEATURE REQUEST
(Maybe, related to #414)

- What is the current behavior?
In case of using editorial workflow and GitHub backend.

When we create entry with URI-unsafe characters in title like 日本語のタイトル or عنوان فارسی, we can't create PR correctly (It is created with the title of empty string)

- What is the expected behavior?

If we want to create entry with URI-unsafe characters, we only do that slugify URI-safe characters.
As below

slugFn("日本語のタイトル") // expect "日本語のタイトル"
slugFn("日本語 Abc タイトル") // expect "日本語-abc-タイトル"

- Please mention your node.js, and operating system version.

v8.2.1

@erquhart
Copy link
Contributor

erquhart commented Sep 8, 2017

Should have been addressed by #414, please re-open if still an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants