-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to a smaller slugifier. #607
Comments
@biilmann suggested using If we use this we may need to add the |
Another option: The |
If urlize can indeed do the trick, we should use it. |
Possible slugifier tests: |
So here is what WordPress does slugification:
@erquhart What's your opinion on the best way to do this? |
Not sure when this conversion would occur - would the resulting filename have these characters encoded? |
@erquhart Yes, in almost every case they would have to. |
Just testing -- both DatoCMS and Forestry strip unsafe chars from the slug. |
If it's par for the course and simpler, let's do it. |
So we have three options:
|
@biilmann @erquhart I'm trying to understand why the urlize function seems to leave some reserved characters in the URL. The list of RFC3986 unreserved characters is |
Currently, we use the
slug
module for creating URL slugs from titles. The problem is thatslug
bundles an entire Unicode lookup table, and that gets bundled into our distributable. it currently accounts for 30.5% of our bundle size. This should probably be changed to something a little lighter weight.Related to #328.
The text was updated successfully, but these errors were encountered: