Fix button alignment on older safari #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for netlify-cms-www ready! Built with commit 903fe13 |
|
Deploy preview for cms-demo ready! Built with commit 903fe13 |
|
Thanks @maciejmatu! Working on getting a Browserstack account for Netlify CMS testing, should have it soon, at which point we can test this PR out. |
erquhart
suggested changes
Apr 11, 2018
erquhart
approved these changes
Apr 12, 2018
There was a problem hiding this comment.
Tested, fixes confirmed in Safari 10, no regressions in latest Chrome.
Thanks @maciejmatu!
erquhart
force-pushed
the
fix-buttons-safari
branch
from
e34c4d6 to
903fe13
Compare
tech4him1
approved these changes
Apr 12, 2018
|
Awesome, I'm really happy it works 😀 |
brianlmacdonald
pushed a commit
to brianlmacdonald/netlify-cms
that referenced
this pull request
May 23, 2018
* Fix button alignment on older safari * Add @maciejmatu to contributors
brianlmacdonald
pushed a commit
to brianlmacdonald/netlify-cms
that referenced
this pull request
May 23, 2018
Partial revert of decaporg#1227.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Fix issue with misaligned button icons on older browsers. - closes #914
This issue was connected to a flex-bug, that disallowed adding
display: flexto certain HTML elements such as<button>https://bugs.webkit.org/show_bug.cgi?id=169700
- Test plan
Testing this fix requires an older version of safari, or access to browserstack 😞 (I tested it, but it would be good, for somebody else to also take a look).
- Description for the changelog
Fix issue with misaligned button icons on older browsers.
- A picture of a cute animal (not mandatory but encouraged)
Blob fish is the best