Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXPERIMENT w/preact #400

Closed
wants to merge 2 commits into from
Closed

EXPERIMENT w/preact #400

wants to merge 2 commits into from

Conversation

bdougie
Copy link
Contributor

@bdougie bdougie commented May 3, 2017

*This is an experiment and not meant to be merged!

- Summary
This PR is the result of an internal discussion happening in the internal Netlify Slack. Can we try Preact on the CMS and what is the limitation? This is a branch I created 2 months ago when I created this issue #328. I originally thought there were issues with it but I am not seeing any issues by just simply adding preact-compat.

- Test plan
Run the example app from this deploy preview and report issues with this idea.

Also feel free to suggest alternatives

- A picture of a cute animal (not mandatory but encouraged)
download

@bdougie bdougie force-pushed the experiment-with-preact branch from 4317b6b to 57322e8 Compare May 3, 2017 17:33
@bdougie
Copy link
Contributor Author

bdougie commented May 3, 2017

First issue I have found is that logging in does work and renders the browser unusable 😬

screenshot 2017-05-03 11 32 22

I think it is the way we handle the redirecting after authentication

@verythorough
Copy link
Contributor

Not relevant to the code, but that mouse in a sweater demands comment.

@bdougie
Copy link
Contributor Author

bdougie commented May 4, 2017

Feel free to reopen, but I am going to close this for now since there is a pretty gnarly bug causing the login for the example app to kill your browser tab. I will test locally later.

@bdougie bdougie closed this May 4, 2017
@ghost
Copy link

ghost commented May 14, 2017

@bdougie I love your spikes! You may find this interesting, as it provides a scaffold for starting universal apps with React, Preact, Inferno and Rax, and could provide some insight on how best to start structuring the architecture for the eventual migration away from React: https://github.com/jaredpalmer/razzle

@bdougie
Copy link
Contributor Author

bdougie commented May 16, 2017

Thanks for the tip @JHabdas. I think I might put some playtime with razzle and explore this. Seems like a great tool to start an internal side project

@talves talves deleted the experiment-with-preact branch May 17, 2018 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants