-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address issue #323 and enable GHE Auth #491
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
de04389
Prevent unauthorized CMS access & Enable GHE usage
tortilaman 2a89f3e
Refactor of new 'isCollaborator' GitHub API method
tortilaman 7d9b14c
Merge remote-tracking branch 'netlify/master'
tortilaman 049ef33
fixed conflicts
tortilaman d9b5edf
Merge remote-tracking branch 'netlify/master'
tortilaman ea32e9c
Merge remote-tracking branch 'netlify/master' into unauthorized-backe…
tortilaman 06cb4ca
Fix to check for general repo push access instead of "contributor"
tortilaman 8937c7d
Merge branch 'unauthorized-backend-fix'
tortilaman f2f8b26
Update to .gitignore
tortilaman 9ef3d05
Remove some outdated checks
tortilaman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,3 +6,5 @@ npm-debug.log | |
.tern-project | ||
yarn-error.log | ||
.vscode/ | ||
manifest.yml | ||
.imdone/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,7 @@ | ||
import { currentBackend } from '../backends/backend'; | ||
import { actions as notifActions } from 'redux-notifications'; | ||
|
||
const { notifSend } = notifActions; | ||
|
||
export const AUTH_REQUEST = 'AUTH_REQUEST'; | ||
export const AUTH_SUCCESS = 'AUTH_SUCCESS'; | ||
|
@@ -60,6 +63,11 @@ export function loginUser(credentials) { | |
dispatch(authenticate(user)); | ||
}) | ||
.catch((error) => { | ||
dispatch(notifSend({ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍, this is a long-awaited change. |
||
message: `${ error.message }`, | ||
kind: 'warning', | ||
dismissAfter: 8000, | ||
})); | ||
dispatch(authError(error)); | ||
}); | ||
}; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
.root { | ||
display: flex; | ||
flex-flow: column nowrap; | ||
align-items: center; | ||
justify-content: center; | ||
height: 100vh; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Today I learned you can't do full destructuring in an
import
call - I was going to suggestimport { actions: { notifSend } } from 'redux-notifications';
, but that syntax is only supported for assignment, not imports).