Disable "Save" button when entry has not been changed. #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erquhart
suggested changes
Sep 9, 2017
There was a problem hiding this comment.
@tech4him1 thanks for this! I agree, changing the prop name makes sense, probably showSave.
You'll also need to update the Jest snapshots so the test passes (use npm test -- -u).
|
@erquhart I changed it to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Fixes #573.
This disables the "Save" button until a user has changed an entry. This also applies to new entries -- the user must modify a field before the "Save" button works.
@erquhart Do you think it is worth naming the prop that is passed to the component something other than
hasChanged, kind of like was done forshowDelete?- Test plan
Manually tested using example config.
- Description for the changelog
Disable "Save" button when entry has no changes.
- A picture of a cute animal (not mandatory but encouraged)