Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add contributors to README #599

Merged
merged 2 commits into from
Sep 13, 2017
Merged

Docs: Add contributors to README #599

merged 2 commits into from
Sep 13, 2017

Conversation

DirtyF
Copy link
Contributor

@DirtyF DirtyF commented Sep 13, 2017

Fix #533

All existing 46 contributors were added to the README with the help of all-contributor-cli.

netlify-cms-contributors

Two new npm scripts are available on development:

  • contributors:add to add a new contributor,
  • contributors:generate to regenerate the file when changes are made to the .all-contributorsrc config JSON file. (e.g. in case one want to complete with type contributions)

P.S: I opened an issue on the ability to update with all current contributors at once. I thought that was the point of the generate command.

/cc @verythorough

Copy link
Contributor

@verythorough verythorough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I'm so glad to have it. At some point, we'll want to get this to display on netlifycms.org via the netlify-cms-www repo. I imagine we'll pull directly from the json file and style it up pretty. 😄 Feel free to file an issue for that.

We'll also want to pull more contributors into that list - people writing tutorial blog posts, building template sites, filing detailed bug reports, etc.

Going forward, we'll want to remember to have people add themselves to the list when they make a first time contribution, too. :)

@verythorough
Copy link
Contributor

@Benaiah or @erquhart feel free to merge if everything looks good to you.

Copy link
Contributor

@Benaiah Benaiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@verythorough verythorough merged commit 94a3941 into decaporg:master Sep 13, 2017
@DirtyF DirtyF deleted the add-contributors branch September 13, 2017 23:26
tech4him1 added a commit that referenced this pull request Sep 16, 2017
tech4him1 added a commit that referenced this pull request Sep 16, 2017
Remove NPM lockfile from #599 and add Yarn one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants