Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use babel-preset-env instead of the yearly presets. #694

Merged
merged 1 commit into from
Oct 19, 2017
Merged

Conversation

tech4him1
Copy link
Contributor

@tech4him1 tech4him1 commented Oct 14, 2017

- Summary

This allows only the transpilation needed for the supported browsers to be done. It also allows us to use the upgrades from ES2016 and ES2017 without needing to add a separate preset.

- Test plan

Manual testing showed no regressions.

- Description for the changelog

Use babel-preset-env instead of the yearly presets.

- A picture of a cute animal (not mandatory but encouraged)

@tech4him1 tech4him1 requested review from Benaiah and erquhart October 14, 2017 15:39
@tech4him1 tech4him1 changed the title Use babel-preset-env instead of the yearly presets. WIP: Use babel-preset-env instead of the yearly presets. Oct 14, 2017
This allows only the transpilation needed for the supported browsers to
be done. It also allows us to use the upgrades from ES2016 and ES2017
without needing to add a seperate preset.
@tech4him1 tech4him1 changed the title WIP: Use babel-preset-env instead of the yearly presets. Use babel-preset-env instead of the yearly presets. Oct 14, 2017
@tech4him1
Copy link
Contributor Author

Just as a side note, this should not affect any of the issues we were dealing with with storybook deps: those are separate.

Copy link
Contributor

@Benaiah Benaiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erquhart erquhart merged commit c58e2ee into master Oct 19, 2017
@erquhart erquhart deleted the babel-env branch October 19, 2017 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants