Switch from react-simple-dnd to react-dnd.
#705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tech4him1
changed the title
react-simple-dnd to react-dnd.react-simple-dnd to react-dnd.
erquhart
suggested changes
Oct 20, 2017
There was a problem hiding this comment.
@tech4him1 just to keep this parseable, we should at least split out the internals so that the implementation in UnpublishedListing is about the same. We could keep the drag and drop primitives in a directory under src/components/UI.
Thoughts?
tech4him1
force-pushed
the
react-dnd
branch
7 times, most recently
from
e5d156d to
a859c40
Compare
`react-simple-dnd` is just a wrapper for `react-dnd`, and it doesn't support React 16. This PR changes to using the underlying library directly.
erquhart
approved these changes
Oct 23, 2017
| @@ -11,6 +11,9 @@ import Button from 'react-toolbox/lib/button'; | |||
| import UnpublishedListingCardMeta from './UnpublishedListingCardMeta.js'; | |||
| import { status, statusDescriptions } from '../../constants/publishModes'; | |||
|
|
|||
| // This is a namespace so that we can only drop these elements on a DropTarget with the same | |||
|
Going to go ahead and merge since this is mostly a port and fairly straightforward (and blocking the React 16 update). |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
react-simple-dndis just a wrapper forreact-dnd, and it doesn't support React 16. This PR changes to using the underlying library directly.- Test plan
Manually tested unpublished entries drag-and-drop cards.
- Description for the changelog
Switch from
react-simple-dndtoreact-dnd.- A picture of a cute animal (not mandatory but encouraged)