Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup file formatters. #759

Merged
merged 5 commits into from
Oct 30, 2017
Merged

Cleanup file formatters. #759

merged 5 commits into from
Oct 30, 2017

Conversation

tech4him1
Copy link
Contributor

@tech4him1 tech4him1 commented Oct 30, 2017

- Summary

This PR aims to clean up the /src/formats code.

@erquhart @Benaiah What do you think on "Use same parsers for files and frontmatter."? I think this will be better to retain consistency in the future -- so things like AssetProxy and Moment.js can be interpreted correctly in frontmatter as well (instead of just in the data-file formatters).

FOR REVIEW: The easiest way to review this PR will probably be to review each commit separately, the history should be clean.

- Test plan

Tested manually with example site to ensure files are still being saved with correct format/extension.

- Description for the changelog

Cleanup file formatters.

- A picture of a cute animal (not mandatory but encouraged)

@tech4him1 tech4him1 force-pushed the cleanup-formats branch 2 times, most recently from d96a745 to 7cec472 Compare October 30, 2017 00:29
@tech4him1 tech4him1 changed the title WIP: Cleanup file formatters. Cleanup file formatters. Oct 30, 2017
Copy link
Contributor

@Benaiah Benaiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants