forked from nodejs/node
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
doc: fix http.ClientRequest method descriptions fix documentation for methods getHeader, setHeader and removeHeader for http.ClientRequest class. The documentation said these functions can be called but they're wasn't describe into the API description yet. add parameters and general description for each methods. PR-URL: nodejs#15163 Fixes: nodejs#15048 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> assert: use Same-value equality in deepStrictEqual PR-URL: nodejs#15398 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> formatting fix and scar deleted
- Loading branch information
Showing
3 changed files
with
75 additions
and
49 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
run `git fetch` | ||
11:33 AM `git checkout test-buffer-edit+ | ||
|
||
./node tools/eslint/bin/eslint.js --rulesdir=tools/eslint-rules --fix lib/buffer.js | ||
|
||
node benchmark/buffers/buffer-from.js | ||
./node test/parallel/test-buffer-from.js | ||
debugger;Buffer.from(new Uint8Array([0x74, 0x65, 0x73, 0x74])); | ||
|
||
|
||
# Pastebin TyYDdZcH | ||
if (typeof value[Symbol.toPrimitive] === 'function') { | ||
return Buffer.from(value[Symbol.toPrimitive]('string'), encodingOrOffset, length); | ||
} | ||
|
||
=> | ||
|
||
Buffer.from(value[Symbol.toPrimitive]('string'), encodingOrOffset, length); | ||
|
||
=> | ||
|
||
Buffer.from(someFunc('string'), encodingOrOffset, length); | ||
|
||
=> | ||
|
||
Buffer.from('test', 'utf-8', undefined) | ||
|
||
=> | ||
|
||
Buffer([0x74, 0x65, 0x73, 0x74]) | ||
|
||
buffer file: inline for resume | ||
|
||
performance was bad | ||
function call was only used once. | ||
opportunity for refactoring | ||
inline function in place of function call. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
"binary", "filename", "configuration", "rate", "time" |