Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add permissions to default scene json #513

Merged
merged 3 commits into from
Aug 31, 2020
Merged

chore: add permissions to default scene json #513

merged 3 commits into from
Aug 31, 2020

Conversation

nchamo
Copy link
Contributor

@nchamo nchamo commented Aug 31, 2020 •
edited
Loading

This PR is doing two things:

  1. We are adding the requiredPermissions property to the default scene.json file, so people know it exists
  2. We are upgrading the version of dcl-catalyst-client. This new version calculates the timestamp of the deployment with an external API, so if the user that is currently deploying has a wrong time on their local machine, the deployment will still succeed.

@nchamo nchamo self-assigned this Aug 31, 2020
@nchamo nchamo requested a review from nearnshaw August 31, 2020 15:48
@nchamo nchamo merged commit 47dc03c into master Aug 31, 2020
@nchamo nchamo deleted the chore/add-permissions-to-defaul-scene-json branch August 31, 2020 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nearnshaw nearnshaw nearnshaw approved these changes

Assignees

@nchamo nchamo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nchamo @nearnshaw