Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly parse multiple service blocks #66

Merged

Conversation

TheTechmage
Copy link
Collaborator

Turns out, we were only using the last services block and we were discarding the rest. This PR fixes that by appending each service to the global service array in the diddoc

Signed-off-by: Colton Wolkins (Laptop) <colton@indicio.tech>
Copy link
Member

@dbluhm dbluhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dbluhm dbluhm merged commit e0b537c into decentralized-identity:main Dec 1, 2023
@TheTechmage TheTechmage deleted the fix/multiple-services branch December 8, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants