#249- only import 'level' when it's actually used
#254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcrousso
requested review from
mistermoe,
csuwildcat and
thehenrytsai
as code owners
shamilovtim
previously approved these changes
Mar 9, 2023
dcrousso
force-pushed
the
dcrousso/avoid-importing-level-unless-actually-used
branch
from
335a7fa to
d5a2b51
Compare
shamilovtim
previously approved these changes
Mar 9, 2023
thehenrytsai
reviewed
Mar 9, 2023
i.e. if a developer provides their own `createLevelDatabase` then we will use that instead of `'level'` in order to support this for both node and browser, we need to switch to using dynamic `import` (instead of `require`, as that's not defined for node when `"type": "module"`) most of this commit is changing sync logic to `async` for that purpose (though it also allows for more flexibility when providing a custom `createLevelDatabase`)
dcrousso
force-pushed
the
dcrousso/avoid-importing-level-unless-actually-used
branch
from
d5a2b51 to
974c60a
Compare
|
@thehenrytsai can you publish an unstable version of this so @shamilovtim can consume? |
This one can probably just get merged. I need the unstable of the other PR and this rebased into that PR first |
thehenrytsai
approved these changes
Mar 10, 2023
|
@mistermoe and @shamilovtim, approved. Letting @dcrousso have the honor of merging. Feel free to merge if you can't wait. |
dcrousso
deleted the
dcrousso/avoid-importing-level-unless-actually-used
branch
thehenrytsai
added a commit
that referenced
this pull request
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i.e. if a developer provides their own
createLevelDatabasethen we will use that instead of'level'in order to support this for both node and browser, we need to switch to using dynamic
import(instead ofrequire, as that's not defined for node when"type": "module")most of this commit is changing sync logic to
asyncfor that purpose (though it also allows for more flexibility when providing a customcreateLevelDatabase)