Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proposal] add/specify 'alsoKnownAs' property for ethr-did #94

Closed
3 tasks
nikolockenvitz opened this issue Nov 12, 2020 · 3 comments
Closed
3 tasks

[proposal] add/specify 'alsoKnownAs' property for ethr-did #94

nikolockenvitz opened this issue Nov 12, 2020 · 3 comments
Labels
help wanted Extra attention is needed incomplete This is not well defined. Ask for clarification before starting work

Comments

@nikolockenvitz
Copy link
Contributor

As already mentioned in decentralized-identity/veramo#260 the DID spec includes the alsoKnownAs property and should be specified and added for ethr-did. Before opening a PR directly, I wanted to propose my ideas here and get some feedback.

update
I would think the easiest is to use the setAttribute/revokeAttribute method of the ethr did registry smart contract. For the attribute name I would think of did/aka or did/alsoKnownAs. Actually I would prefer the latter one because it's more explicit and length doesn't matter as it is padded to 32 bytes anyway. In contrast to public keys and services, the attribute name is completly static and doesn't include any other information, so it's no problem to have a long name. The attribute value could just be the hex-encoded identifier/URI that should be added to the alsoKnownAs property.

Options:

  • did/aka
  • did/alsoKnownAs (← my suggestion)
  • ...

resolve
When resolving the DID document, an array of all these values (that didn't expired yet or have been revoked afterwards) should be returned. One question to be answered is, whether alsoKnownAs should be an empty array or whether this property shouldn't be included in the DID document at all if there are no values. It suggest to do it similar to the others (public key, service, ...) and include the alsoKnownAs property only if the array is not empty.

Options:

  • { id: "...", alsoKnownAs: [] }
  • { id: "..." } (← my suggestion)
  • ...

Your opinion on that / feedback / any other ideas?

Checklist for next steps:

  • update ethr did spec
  • write tests
  • update wrapDidDocument() method of ethr-did-resolver
@nikolockenvitz
Copy link
Contributor Author

I implemented my proposed changes (see linked pull request). Feedback is welcome.

@mirceanis mirceanis added this to todo in typescript libs did-core spec compliance via automation Dec 10, 2020
@rado0x54
Copy link

rado0x54 commented May 6, 2021

Updated link to spec: https://w3c.github.io/did-core/#also-known-as
Feature is currently at risk.

@rado0x54 rado0x54 added the help wanted Extra attention is needed label May 6, 2021
@stale
Copy link

stale bot commented Jun 5, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the incomplete This is not well defined. Ask for clarification before starting work label Jun 5, 2021
@stale stale bot closed this as completed Jun 12, 2021
typescript libs did-core spec compliance automation moved this from todo to done Jun 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed incomplete This is not well defined. Ask for clarification before starting work
Development

Successfully merging a pull request may close this issue.

3 participants