Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIDs: alsoKnownAs property #260

Closed
nikolockenvitz opened this issue Nov 11, 2020 · 6 comments
Closed

DIDs: alsoKnownAs property #260

nikolockenvitz opened this issue Nov 11, 2020 · 6 comments
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@nikolockenvitz
Copy link

nikolockenvitz commented Nov 11, 2020

The alsoKnownAs property has been added to the DID spec recently.
It's basically a string array of some identifiers (URIs) by which the DID subject can also be identified. (see the corresponding section in w3c did-core)

I was wondering whether it is planned to include that in daf-ethr-did too?

Possible implementation
Could be done building upon the setAttribute method of the ethr-did-registry, e.g. did/aka + hex encoded string.
Similar to the other methods in daf-ethr-dids identity-provider (beta-branch) it would just be something like async addAlsoKnownAs({ identity, service, options }: { identity: IIdentity; alsoKnownAs: string; options?: any }, context: IContext): Promise<any>

What's your opinion on that?
(Should I also mention that in ethr-did-resolver somehow?)

Do you have an estimation when the beta-branch will be merged? (Thinking about whether it makes sense to include that in the current version or just go for beta-branch).

EDIT: maybe someone could remove the bug label and add something like feature or feature-request...

@nikolockenvitz nikolockenvitz added the bug Something isn't working label Nov 11, 2020
@mirceanis mirceanis added enhancement New feature or request and removed bug Something isn't working labels Nov 12, 2020
@mirceanis
Copy link
Member

Thanks for flagging this.
That sounds like a good proposal and it would be fairly easy to add to daf-ethr-did.
However, the resolver would also need to be updated to support this new attribute type.
Let's agree on a format for the did/aka entries in ethr-did spec first and then it would need to be implemented in daf and ethr-did resolver simultaneously for it to work.

@stale
Copy link

stale bot commented Jan 11, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jan 11, 2021
@nikolockenvitz
Copy link
Author

Still an open issue that should be worked on IMO

@stale stale bot removed the wontfix This will not be worked on label Jan 11, 2021
@mirceanis
Copy link
Member

Still an open issue that should be worked on IMO

Yes, it is. We're waiting for the DID spec to become a bit more stable before committing to this.

@stale
Copy link

stale bot commented Mar 19, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Mar 19, 2021
@mirceanis mirceanis removed the wontfix This will not be worked on label Mar 26, 2021
@stale
Copy link

stale bot commented Jun 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants