Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update specs regarding versionId #125

Merged
merged 2 commits into from
Apr 23, 2021
Merged

Conversation

mirceanis
Copy link
Member

Update the spec to detail the changes from v4.2.0 (#121)

relates to #119, #121
also clarifies some changes from #99 about metadata.

I removed some sections of the readme that were duplicating entries from the spec.

@mirceanis mirceanis requested a review from awoie April 20, 2021 13:15
Copy link
Member

@awoie awoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess the general question is if we want to keep two "instances" of the did:ethr spec. the official did method registry refers to https://github.com/decentralized-identity/ethr-did-resolver/blob/master/doc/did-method-spec.md and i guess we could use this page to just talk about implementation stuff in a less formal way.

doc/did-method-spec.md Outdated Show resolved Hide resolved
doc/did-method-spec.md Show resolved Hide resolved
doc/did-method-spec.md Show resolved Hide resolved
doc/did-method-spec.md Outdated Show resolved Hide resolved
doc/did-method-spec.md Outdated Show resolved Hide resolved
doc/did-method-spec.md Show resolved Hide resolved
doc/did-method-spec.md Outdated Show resolved Hide resolved
doc/did-method-spec.md Outdated Show resolved Hide resolved
doc/did-method-spec.md Show resolved Hide resolved
doc/did-method-spec.md Show resolved Hide resolved
@mirceanis
Copy link
Member Author

i guess the general question is if we want to keep two "instances" of the did:ethr spec. the official did method registry refers to https://github.com/decentralized-identity/ethr-did-resolver/blob/master/doc/did-method-spec.md and i guess we could use this page to just talk about implementation stuff in a less formal way.

I don't understand. This pr is an update to that spec. Where is the duplicate you are referring to?

@mirceanis
Copy link
Member Author

@awoie I addressed all the issues you raised.
Please re-review, thanks!

@mirceanis mirceanis requested a review from awoie April 22, 2021 18:04
Copy link
Member

@awoie awoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mirceanis mirceanis merged commit 39f786e into master Apr 23, 2021
@mirceanis mirceanis deleted the update-spec-with-versioning branch April 23, 2021 08:46
@uport-automation-bot
Copy link
Collaborator

🎉 This PR is included in version 4.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants