-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update specs regarding versionId
#125
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i guess the general question is if we want to keep two "instances" of the did:ethr spec. the official did method registry refers to https://github.com/decentralized-identity/ethr-did-resolver/blob/master/doc/did-method-spec.md and i guess we could use this page to just talk about implementation stuff in a less formal way.
I don't understand. This pr is an update to that spec. Where is the duplicate you are referring to? |
34ea440
to
529d8c0
Compare
529d8c0
to
4e4e274
Compare
@awoie I addressed all the issues you raised. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
🎉 This PR is included in version 4.3.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Update the spec to detail the changes from v4.2.0 (#121)
relates to #119, #121
also clarifies some changes from #99 about metadata.
I removed some sections of the readme that were duplicating entries from the spec.