Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Disable schema validation by default #278

Merged
merged 1 commit into from
Nov 23, 2020
Merged

fix: Disable schema validation by default #278

merged 1 commit into from
Nov 23, 2020

Conversation

mirceanis
Copy link
Member

@mirceanis mirceanis commented Nov 23, 2020 •
edited
Loading

  • add schemaValidation flag to IAgentOptions to enable validation of inputs and outputs.
  • update config templates to set schemaValidation flag to false
  • update integration tests to consider schema validation

Closes #255
Closes #275

@mirceanis mirceanis added this to the DAF 7.0 milestone Nov 23, 2020
@mirceanis mirceanis marked this pull request as draft November 23, 2020 14:14
@mirceanis
fix: Disable schema validation by default
90e9219 
* add `schemaValidation` flag to `IAgentOptions` to enable validation of inputs and outputs.
* update config templates to set `schemaValidation` flag to false
* update integration tests to consider validation

Closes #255
Closes #275
@mirceanis mirceanis force-pushed the fix/255-disable-schema-validation branch from 050e5f0 to 90e9219 Compare November 23, 2020 17:12
@codecov
Copy link

codecov bot commented Nov 23, 2020

Codecov Report

Merging #278 (90e9219) into beta (b97ff3b) will decrease coverage by 0.15%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             beta     #278      +/-   ##
==========================================
- Coverage   69.81%   69.65%   -0.16%     
==========================================
  Files          70       70              
  Lines        1693     1694       +1     
  Branches      303      304       +1     
==========================================
- Hits         1182     1180       -2     
- Misses        414      416       +2     
- Partials       97       98       +1

@mirceanis mirceanis marked this pull request as ready for review November 23, 2020 17:17
@mirceanis mirceanis merged commit 7bb77cd into beta Nov 23, 2020
@mirceanis mirceanis deleted the fix/255-disable-schema-validation branch November 23, 2020 17:18
mirceanis added a commit that referenced this pull request Nov 24, 2020
@mirceanis
chore: Start with schemaValidation false in default CLI config
4c6c3ab 
relates to #278
fixes #275
fixes #255
mirceanis added a commit that referenced this pull request Nov 24, 2020
@mirceanis
fix: Disable schemaValidation in CLI default config (#280)
8785a5b 
relates to #278
fixes #275
fixes #255
@mirceanis mirceanis mentioned this pull request Nov 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonas-notcat simonas-notcat simonas-notcat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
DAF 7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mirceanis @simonas-notcat