Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 'Prevent showing the dropdown menu when changing orientation of mobile devices' to v0.28 #12929

Conversation

andreslucena
Copy link
Member

🎩 What? Why?

Backport #12858 to v0.28

♥️ Thank you!

… devices

* Prevent showing the dropdown menu when changing orientation of mobile devices

* Make the dropdown menu to work when changing orientation of mobile devices

* Fix string capitalization in 'Filter and Search'

* Fix rubocop offense

* Fix a11y tests on dropdown menus with children element

We need to disable focus in the children element of the hidden menu.
If not, we have an AXE error:

> aria-hidden-focus: ARIA hidden element must not be focusable or contain
focusable elements
@andreslucena andreslucena added backport Pull Requests that are a backport for a fixed bug javascript Pull requests that update Javascript code module: accountability module: admin module: conferences module: core type: fix PRs that implement a fix for a bug labels May 31, 2024
Copy link
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alecslupu alecslupu added this to the 0.28.2 milestone Jun 3, 2024
@alecslupu alecslupu merged commit c68fc17 into release/0.28-stable Jun 3, 2024
106 of 107 checks passed
@alecslupu alecslupu deleted the backport/0.28/prevent-showing-the-dropdown-m-12858 branch June 3, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Pull Requests that are a backport for a fixed bug javascript Pull requests that update Javascript code module: accountability module: admin module: conferences module: core type: fix PRs that implement a fix for a bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants