break build on ineffassign, and fixed a few cases

.golangci.yml

@@ -4,6 +4,7 @@ linters:
   disable-all: true
   enable:
     - bidichk
+    - ineffassign
     - unused
     - goconst
     - gofmt

cmd/utility_test.go

@@ -15,15 +15,15 @@ func TestPackageCfg(t *testing.T) {
 	// Test error cases first.
 	args := []string{"@"}
 
-	cfg, err := packageCfg(args)
+	_, err := packageCfg(args)
 	assert.Error(t, err, "it has an api_key_error")
 
 	// Test non-error case.
 	args = []string{"@", "echo 'hello world'", "&& sleep 0.5", "&& ps aux | grep foo"}
 
 	viper.Set("tips_api_key", "foo")
 	viper.Set("tailnet", "bar")
-	cfg, err = packageCfg(args)
+	cfg, err := packageCfg(args)
 
 	assert.NoError(t, err)
 	assert.NotNil(t, cfg)

pkg/filters_test.go

@@ -10,16 +10,16 @@ func TestParseFilter(t *testing.T) {
 	// Note: much more robust testing of the parser occurs in the filtercomp package.
 	// It makes this testing somewhat redundant.
 
-	// An filter expression with imbalanced parenthesis should return an error.
-	ast, err := ParseFilter("(hello, world")
+	// A filter expression with imbalanced parenthesis should return an error.
+	_, err := ParseFilter("(hello, world")
 	assert.Error(t, err, "imbalanced parenthesis detected")
 
 	// An empty filter should return no error with a nil ast.
-	ast, err = ParseFilter("")
+	ast, err := ParseFilter("")
 	assert.NoError(t, err)
 	assert.Nil(t, ast)
 
 	// An empty filter should return no error with a nil ast.
-	ast, err = ParseFilter("how are you doing?")
+	_, err = ParseFilter("how are you doing?")
 	assert.Error(t, err, "parser did not run to completion, tokens were not fully consumed")
 }