Remove entry ref and re-arrange top-level imports #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Description**xx Remove `entry_ref` functions and associated module **Motivation** The value add of `*entry_ref` was that you could pass a `&Q` to do the lookup, just like the `get` method allows. On insert, then the `&Q` would be converted to a `K`. I didn't think the value of that delayed conversion was worth keeping the whole other module around, since you can emulate the `entry*` interface using `get`/`insert` calls directly.
**Description** - Remove the glob export of the `nodes` module in the `lib.rs` file and make `raw` module public - Fix all related imports, rename the files, etc **Motivation** I think that `raw` communicates the contents of the module better than `nodes`, since that module contains all the trie-related stuff that outside of the structured `TreeMap` interface.
**Description** A couple of nightly features flags have been merged, so we can remove them. One flag was even returning an error saying it didn't exist? Once we bump the MSRV past the point where the same features would appear on stable, we can remove the corresponding functions from the `rust_nightly_apis` module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG file has the details and motivation, this is mostly re-organizing