Add optional support for custom TreeMap allocator #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Description** - Modify the TreeMap interface so that it exposes a new generic parameter for the allocator, defaulting to the Rust global allocator. - Modify the internal tree operations to use the allocator stored in the tree for insert/delete/clone/dealloc operations - Add a new feature flag and optional dependency to consume the `Allocator` trait on the stable toolchain, also integrate with the `nightly` feature flag + toolchain to use that trait. - Also fix a bunch of clippy lints that are coming in on the latest nightly toolchains - Converting explicit lifetimes to `'_` Note: The current OOM behavior is to panic. I may change this in the future to support an explicit `Err(...)`, but not to start at least. **Motivation** I think custom allocators are a very useful feature for making the the library more flexible and useful in `no_std` environments, or other non-standard scenarios. I was even able to experiment with using `bumpalo` as the custom allocator, which I think is neat. **Testing Done** I added some unit tests which create various custom allocators and use those to create/update/query/delete from `TreeMap`.
Also fix some clippy lints.
./scripts/bench-against.sh mainPerf results: Mostly small negative changes (+1%-2% in instructions and L1 hits), but I'm not too concerned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allocatortrait on the stable toolchain, also integrate with thenightlyfeature flag + toolchain to use that trait.'_Note: The current OOM behavior is to panic. I may change this in the future to support an explicit
Err(...), but not to start at least.Motivation
I think custom allocators are a very useful feature for making the the library more flexible and useful in
no_stdenvironments, or other non-standard scenarios. I was even able to experiment with usingbumpaloas the custom allocator, which I think is neat.Testing Done
I added some unit tests which create various custom allocators and use those to create/update/query/delete from
TreeMap.