[Shopify] Fix pagination loader PLP #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tagging OptionsShould a new tag be published when this PR is merged?
|
luanargolodev
force-pushed
the
fix/pagination
branch
from
f6e7a7a
to
84935c2
Compare
guitavano
reviewed
Oct 4, 2024
guitavano
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this Contribution About?
This PR aims to fix pagination in the Shopify app's PLP loader.
What happens?
Technically, when we enter the PLP home page, we would be visiting the first page. The thing is, in the loader, it is inserting the page as 0 and ends up "messing up" the pagination, since the nextPage and previousPage are done from the current pagination.
Exemplifying
Considering that we enter the /accessories/clothes page and when entering the first page, we do not have the attribute ?page=1, the loader would automatically return that we were on page 0.
When pagination to the next page, it would be set to the url ?page=1 instead of ?page=2. When returning to the pagination, it would be set to the url ?page=0.