wire: Remove TxSerializeWitnessSigning. #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
wire_remove_witness_signing
branch
from
d8827ae
to
cd555d7
Compare
jrick
approved these changes
Apr 30, 2018
davecgh
force-pushed
the
wire_remove_witness_signing
branch
2 times, most recently
from
12dd681
to
e7f560d
Compare
This removes the TxSerializeWitnessSigning serialization type since it is no longer required due to implementing it directly in the signature hash calculation function. It also removes all related tests. Although this is technically a change to the wire protocol, the protocol version is not being bumped because nothing ever sends messages using this serialization type as it only applied for calculating signature hashes and really should not have ever been in the wire package to begin with.
davecgh
force-pushed
the
wire_remove_witness_signing
branch
from
e7f560d
to
b3ce2ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This build on top of PR #1179.
This removes the
TxSerializeWitnessSigningserialization type since it is no longer required due to implementing it directly in the signature hash calculation function. It also removes all related tests.Although this is technically a change to the wire protocol, the protocol version is not being bumped because nothing ever sends messages using this serialization type as it only applied for calculating signature hashes and really should not have ever been in the wire package to begin with.