mempool: Use blockchain for tx expiry check. #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This modifies the pruning code to make use of the newly available function in blockchain to test if a transaction is expired. While here, it makes the comments on the functions more consistent with others and moves the unexported definition before the exported function from which it is used.
davecgh
force-pushed
the
mempool_use_blockchain_expired_check
branch
from
22960bf
to
cc6993e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the pruning code to make use of the newly available function in
blockchainto test if a transaction is expired.While here, it makes the comments on the functions more consistent with others and moves the unexported definition before the exported function from which it is used.