dcrjson: Implement xpub import from other wallet and use for address generation #1217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kLkA
force-pushed
the
xpub_for_ticket_purchase
branch
from
3fccd09
to
0f46229
Compare
jrick
reviewed
May 24, 2018
dcrjson/dcrwalletextcmds.go
Outdated
| @@ -248,6 +248,27 @@ func NewImportScriptCmd(hex string, rescan *bool, scanFrom *int) *ImportScriptCm | |||
| return &ImportScriptCmd{hex, rescan, scanFrom} | |||
| } | |||
|
|
|||
| // CreateVotingAccountCmd is a type for handling custom marshaling and | |||
| // unmarshaling of createvotingaccount JSON wallet extension commands. | |||
There was a problem hiding this comment.
JSON-RPC, and there's no need to comment that this is an "extension". We're a different API from bitcoin core at this point.
davecgh
requested changes
May 24, 2018
| func NewCreateVotingAccountCmd(name, pubKey string, childIndex *uint32) *CreateVotingAccountCmd { | ||
| return &CreateVotingAccountCmd{name, pubKey, childIndex} | ||
| } | ||
|
|
There was a problem hiding this comment.
Missing the function comment for godoc and consistency. It'll fail linters as well for that reason.
|
Looks good. Will approve after squash. |
methods help to import and drop xpub key to generate addresses on behalf of another wallet
kLkA
force-pushed
the
xpub_for_ticket_purchase
branch
from
9f478ec
to
569f703
Compare
davecgh
changed the title
davecgh
approved these changes
May 24, 2018
JFixby
pushed a commit
to JFixby/dcrd
that referenced
this pull request
Oct 21, 2018
rpcclient: expose the Node command for RPC API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is corresponding dcrd PR for task
decred/dcrwallet#990
decred/dcrwallet#1137