Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Update some vgo dependencies to use tags. #1219

Merged
merged 1 commit into from
May 24, 2018
Merged

build: Update some vgo dependencies to use tags. #1219

merged 1 commit into from
May 24, 2018

Conversation

davecgh
Copy link
Member

@davecgh davecgh commented May 24, 2018 •
edited
Loading

This PR builds on #1218.

Also, while here, constrain slog in Gopkg.toml to 1.0.0 and update the associated lock file accordingly.

red010b37
red010b37 approved these changes May 24, 2018
View reviewed changes
Copy link

@red010b37 red010b37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates look good

jrick
jrick reviewed May 24, 2018
View reviewed changes
Copy link
Member

@jrick jrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're here, can we also change the constraint in the Gopkg.toml to slog 1.0.0? Wallet is currently constrained to that, and this prevents a solution when solving dependencies.

@davecgh
Copy link
Member Author

davecgh commented May 24, 2018

@jrick: Updated.

@davecgh
build: Update some vgo dependencies to use tags.
d8bc8fb 
Also, while here, constrain slog in Gopkg.toml to 1.0.0 and update the
associated lock file accordingly.
@davecgh davecgh merged commit d8bc8fb into decred:master May 24, 2018
@davecgh davecgh deleted the vgo_use_tags branch May 24, 2018 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@red010b37 red010b37 red010b37 approved these changes

@jrick jrick jrick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davecgh @jrick @red010b37