multi: move extension commands into associated normal command files. #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
requested changes
Jun 1, 2018
dcrjson/chainsvrcmds.go
Outdated
| @@ -28,6 +32,16 @@ const ( | |||
| // ANOneTry indicates the specified host should try to connect once, | |||
| // but it should not be made persistent. | |||
| ANOneTry AddNodeSubCmd = "onetry" | |||
|
|
|||
| // NConnect indicates the specified host that should be connected to. | |||
| NConnect NodeSubCmd = "connect" | |||
There was a problem hiding this comment.
Please do these in separate blocks next to the type it's defined for so it's clear it is an enum.
type AddNodeSubCmd string
const(
ANAdd AddNodeSubCmd = "add"
...
)
type NodeSubCmd string
const (
NConnect NodeSubCmd = "connect"
...
)Also, please define it next to the command it applies to.
dcrjson/chainsvrcmds_test.go
Outdated
| @@ -1017,6 +1017,152 @@ func TestChainSvrCmds(t *testing.T) { | |||
| Message: "test", | |||
| }, | |||
| }, | |||
| { | |||
| name: "debuglevel", | |||
There was a problem hiding this comment.
Please alphabetize all of these for consistency.
dcrjson/chainsvrcmds_test.go
Outdated
| }, | ||
| }, | ||
| { | ||
| name: "debuglevel", |
davecgh
requested changes
Jun 2, 2018
dcrjson/walletsvrcmds_test.go
Outdated
| @@ -1139,6 +1139,121 @@ func TestWalletSvrCmds(t *testing.T) { | |||
| NewPassphrase: "new", | |||
| }, | |||
| }, | |||
| { | |||
| name: "sweepaccount - optionals provided", | |||
There was a problem hiding this comment.
Please alphabetize all of these for consistency.
dcrjson/chainsvrresults.go
Outdated
|
|
||
| // CreateMultiSigResult models the data returned from the createmultisig | ||
| // command. | ||
| type CreateMultiSigResult struct { |
There was a problem hiding this comment.
There are a lot of results that aren't alphabetized here. The only time they shouldn't be is if they are subresults of a field of a specific command in which case that subresult should come before the command result that uses it.
dnldd
force-pushed
the
combine_ext_cmds
branch
3 times, most recently
from
ec6621e
to
7f0c77b
Compare
This consolidates all commands and tests into their respective normalfiles. BtcdConnectedNtfn has been renamed DcrdConnectedNtfn.
davecgh
approved these changes
Jun 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This consolidates all commands and tests into their respective normal
files. BtcdConnectedNtfn has been renamed DcrdConnectedNtfn.
Resolves #1220